feat: prompt user to publish public announcement in discord during metta publish

[yatharth]

No description provided.

[yatharth]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat: prompt user to publish public announcement in discord during metta publish #4527 👈 (View in Graphite)
• feat: run cogames smoke test from source code in child repo #4523
• refactor: reorder jobs in release-cogames.yml to be in execution order #4525
• feat: include package-specific tags in filtered history pushed to child repo during metta publish #4522
• feat: show dry-run preview of what would be pushed to child repo in metta publish #4521
• feat: add smoke test in cogames release workflow #4423
• fix: smoke test caught undeclared dependency on uv in cogames tests #4425
• fix: remove all imports from metta in cogames #4421 : 1 other dependent PR (#4422 )
• fix: manual dispatch of mettagrid/cogame release workflows was broken on certain branches #4419
• feat: wait for mettagrid PyPi release before publishing cogames to PyPi #4418
• feat: clearer warnings when using --force with metta publish #4516
• feat: pin cogames to specific mettagrid version before publishing #4417
• refactor: simplify git and versioning logic in metta publish.py #4416
• refactor: reorganise metta publish.py to prepare for downstream refactor #4415
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

The dry-run check occurs after user prompts, causing unnecessary user interaction in dry-run mode. When dry_run=True, users are still prompted with typer.confirm() (line 281) and typer.edit() (line 298) before the dry-run check at line 306. This means dry-run mode requires full user interaction despite not posting anything.

In typical dry-run workflows, no user interaction should be required. The function should check dry_run at the beginning and skip all interactive prompts:

if dry_run:
    info("Would prompt for public Discord announcement (skipped in dry-run mode)")
    return

# Continue with interactive prompts...
if not typer.confirm(...):
    ...

Suggested change

	if not typer.confirm("Would you like to post a public announcement about this release?", default=False):
	info("Skipping public announcement.")
	return
	# Generate default template message
	_pypi_url = f"https://pypi.org/project/{package.value}/"
	template = textwrap.dedent(
	f"""\
	📦 **{package.value} v{version}** [released]({_pypi_url})!
	- Added support for [blah]
	- Bug fix for [blah]
	"""
	)
	# Open editor for user to compose message
	info("Opening editor to compose public announcement...")
	edited_message = typer.edit(template)
	# Bail if message is empty.
	if edited_message is None or len(edited_message.strip()) == 0:
	info("No message composed. Skipping public announcement.")
	return
	# In dry-run mode, show what would be posted.
	if dry_run:
	info("Would post following message to public Discord:")
	print(edited_message)
	return
	if dry_run:
	info("Would prompt for public Discord announcement (skipped in dry-run mode)")
	return
	if not typer.confirm("Would you like to post a public announcement about this release?", default=False):
	info("Skipping public announcement.")
	return
	# Generate default template message
	_pypi_url = f"https://pypi.org/project/{package.value}/"
	template = textwrap.dedent(
	f"""\
	📦 **{package.value} v{version}** [released]({_pypi_url})!
	- Added support for [blah]
	- Bug fix for [blah]
	"""
	)
	# Open editor for user to compose message
	info("Opening editor to compose public announcement...")
	edited_message = typer.edit(template)
	# Bail if message is empty.
	if edited_message is None or len(edited_message.strip()) == 0:
	info("No message composed. Skipping public announcement.")
	return
	# In dry-run mode, show what would be posted.
	info("Would post following message to public Discord:")
	print(edited_message)
	return

Spotted by Graphite Agent



Is this helpful? React 👍 or 👎 to let us know.