-
Notifications
You must be signed in to change notification settings - Fork 48
feat: add smoke test in cogames release workflow #4423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: yatharth/cogames-remove-uv
Are you sure you want to change the base?
Conversation
dacced5 to
49160b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6d09780 to
d8d118d
Compare
d8d118d to
e397573
Compare
e397573 to
f6a331f
Compare
f6a331f to
fb25c5c
Compare
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.12" | ||
| # Without this, we get "ERROR: Could not install packages due to an OSError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can probably just use a bigger runner instead
nishu-builder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's also make sure we:
- the filter-repo push should also push a tag with the matching version
- this should only checkout packages/cogames
- maybe we do a similar thing for release-mettagrid, and then we can refactor those to use the ~same underlying github action
fb25c5c to
88d63cf
Compare
e50a2d4 to
521db21
Compare

What this PR does
cogamestests pass before it's published to PyPi . . .metta,gridworks, etc.mettagridspecified in cogames'pyproject.tomlExample run
Why this PR does that
cogamesversion that depends onmetta.pyproject.tomlAsana Task