Skip to content

Conversation

@yatharth
Copy link
Contributor

@yatharth yatharth commented Dec 18, 2025

What this PR does

  • Ensure cogames tests pass before it's published to PyPi . . .
    • . . . without the presence of metta, gridworks, etc.
    • . . . using exact version of mettagrid specified in cogames' pyproject.toml

Example run

CleanShot 2025-12-17 at 22.08.57.png

Why this PR does that

  • This serves as the definitive line of defence against accidentally publishing a cogames version that depends on metta.
  • It ensures that cogames works with just the dependencies listed in its pyproject.toml

Asana Task

Copy link
Contributor Author

yatharth commented Dec 18, 2025

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@yatharth yatharth force-pushed the yatharth/cogames-smoke-test branch 2 times, most recently from 6d09780 to d8d118d Compare December 18, 2025 06:20
@yatharth yatharth changed the base branch from yatharth/cogames-forbidden-import-test to graphite-base/4423 December 18, 2025 06:31
@yatharth yatharth force-pushed the yatharth/cogames-smoke-test branch from d8d118d to e397573 Compare December 18, 2025 06:31
@yatharth yatharth changed the base branch from graphite-base/4423 to yatharth/cogames-remove-uv December 18, 2025 06:31
@yatharth yatharth force-pushed the yatharth/cogames-smoke-test branch from e397573 to f6a331f Compare December 18, 2025 06:35
@yatharth yatharth force-pushed the yatharth/cogames-smoke-test branch from f6a331f to fb25c5c Compare December 18, 2025 06:41
- uses: actions/setup-python@v5
with:
python-version: "3.12"
# Without this, we get "ERROR: Could not install packages due to an OSError:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can probably just use a bigger runner instead

Copy link
Contributor

@nishu-builder nishu-builder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also make sure we:

  • the filter-repo push should also push a tag with the matching version
  • this should only checkout packages/cogames
  • maybe we do a similar thing for release-mettagrid, and then we can refactor those to use the ~same underlying github action

@yatharth yatharth force-pushed the yatharth/cogames-smoke-test branch from fb25c5c to 88d63cf Compare December 23, 2025 23:19
@yatharth yatharth force-pushed the yatharth/cogames-remove-uv branch from e50a2d4 to 521db21 Compare December 23, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants