Skip to content

Conversation

@yatharth
Copy link
Contributor

@yatharth yatharth commented Dec 18, 2025

What this PR does

  • Checks which mettagrid version this cogames release depends on
  • Waits for that mettagrid version to be published on PyPi before publishing cogames to PyPi

The time out is 10 minutes

  • The mettagrid release takes about 3–4 minutes
  • Might take a few minutes for PyPi to update
  • Some buffer

If we don't see the mettagrid version published, we bail on publishing cogames to PyPi.

Why this PR does that

Publishing mettagrid might fail, in which case we don't want to publish a version of cogames that depends on that version.

How I tested this

  • I temporarily changed this branch to have mettagrid=={actually_published_version} in cogames/pyproject.toml and manually dispatched the release-cogames workflow from this branch.
    • ✅ Successfully detected the mettagrid version was published, and went ahead with cogames publication (link to run)
  • I then tried with mettagrid=={not_yet_published_version}
    • ✅ Timed out after 10 minutes, and aborted publication of cogames (link to run)

In the first

Asana Task

Copy link
Contributor Author

yatharth commented Dec 18, 2025

@yatharth yatharth marked this pull request as ready for review December 18, 2025 04:18
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@yatharth yatharth force-pushed the yatharth/metta-publish-wait-pypi branch from c2cab16 to 0bbc8d6 Compare December 18, 2025 04:27
@yatharth yatharth force-pushed the yatharth/metta-publish-wait-pypi branch 3 times, most recently from 0d7d5b6 to 4594ac6 Compare December 18, 2025 04:37
@yatharth yatharth force-pushed the yatharth/metta-publish-cogames-version-pinning branch from 99ba40a to 60f83dd Compare December 23, 2025 22:11
@yatharth yatharth force-pushed the yatharth/metta-publish-wait-pypi branch from 4a6ff79 to f151d62 Compare December 23, 2025 22:11
@yatharth yatharth changed the base branch from yatharth/metta-publish-cogames-version-pinning to graphite-base/4418 December 23, 2025 22:27
@yatharth yatharth force-pushed the yatharth/metta-publish-wait-pypi branch from f151d62 to d497f40 Compare December 23, 2025 22:27
@yatharth yatharth changed the base branch from graphite-base/4418 to yatharth/metta-publish-git-force-warning December 23, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants