-
Notifications
You must be signed in to change notification settings - Fork 48
feat: wait for mettagrid PyPi release before publishing cogames to PyPi #4418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: yatharth/metta-publish-git-force-warning
Are you sure you want to change the base?
feat: wait for mettagrid PyPi release before publishing cogames to PyPi #4418
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1bc2870 to
c2cab16
Compare
c2cab16 to
0bbc8d6
Compare
0d7d5b6 to
4594ac6
Compare
4594ac6 to
c5d8691
Compare
4407db3 to
b684fcf
Compare
b684fcf to
4a6ff79
Compare
8a1f72d to
99ba40a
Compare
99ba40a to
60f83dd
Compare
4a6ff79 to
f151d62
Compare
f151d62 to
d497f40
Compare
d497f40 to
fedf197
Compare
fddde41 to
cf8f677
Compare

What this PR does
mettagridversion thiscogamesrelease depends onmettagridversion to be published on PyPi before publishingcogamesto PyPiThe time out is 10 minutes
If we don't see the mettagrid version published, we bail on publishing cogames to PyPi.
Why this PR does that
Publishing
mettagridmight fail, in which case we don't want to publish a version ofcogamesthat depends on that version.How I tested this
mettagrid=={actually_published_version}incogames/pyproject.tomland manually dispatched therelease-cogamesworkflow from this branch.mettagridversion was published, and went ahead with cogames publication (link to run)mettagrid=={not_yet_published_version}In the first
Asana Task