feat: add test to ensure cogames tests do not import from metta #4422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2025
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 18, 2025
This was referenced Dec 18, 2025
| # Check all Python files in the cogames package | ||
| for py_file in iter_python_files(repo_root): | ||
| # Skip this test file itself | ||
| if py_file.name == "test_forbidden_imports.py": |
Contributor
There was a problem hiding this comment.
you can maybe use __file__ or something
| continue | ||
| # Skip explicitly excluded files | ||
| rel_path = str(py_file.relative_to(repo_root)) | ||
| if rel_path in EXCLUDE_FILES: |
Contributor
There was a problem hiding this comment.
seems we should just remove EXCLUDE_FILES usage
nishu-builder
approved these changes
Dec 18, 2025
yatharth
changed the base branch from
yatharth/cogames-forbidden-import-remove
to
graphite-base/4422
This was referenced Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
We had test called
test_forbidden_imports()to prevent imports frommettaincogames.However, it only tested code in
cogames/src, meaningcogames/testscould still import frommetta, as was the case in #4421.Why this PR does that
It's important in publishing
cogamesas a stand-alone package that the tests run by themselves without reference to a private repository.Asana Task