Add CMake build system and and updated README.md#48
Open
jopadan wants to merge 3 commits intodkfans:masterfrom
Open
Add CMake build system and and updated README.md#48jopadan wants to merge 3 commits intodkfans:masterfrom
jopadan wants to merge 3 commits intodkfans:masterfrom
Conversation
Member
|
@jopadan did you close and make a new issue again? there is no reason to do this and only makes the list of closed PR's more messy, and makes it harder to see what the latest changes are, and makes it difficult to follow what has already been discussed on the PR, could you please just do everything in the same PR |
This was referenced Mar 28, 2022
Member
|
I concur, please stop opening new pull request for the same thing. It's going to be squashed anyways, so it's entirely a waste of time trying to make the git log "pretty". If you must insist on making the git log pretty, just force push your own branch if you must. Anyways CMakeOutput.log: |
dotted
reviewed
Mar 28, 2022
| find_package( SDL REQUIRED ) | ||
| target_link_libraries( ${ARG_NAME} PUBLIC ${SDL_LIBRARY} ) | ||
| target_compile_definitions( ${ARG_NAME} PUBLIC ENTRY_CONFIG_USE_SDL ) | ||
| target_link_libraries( ${ARG_NAME} PUBLIC X11 Math::Math ) |
Member
There was a problem hiding this comment.
Any reason for doing Math::Math instead of just m? Seems to work fine just using m - I made a pull request to your repo with the change: jopadan#1
Author
There was a problem hiding this comment.
You need to install libadikted first and run
export PKG_CONFIG_PATH=$PREFIX/${libdir}/pkgconfig && ldconfigI apologize for reopening the pull request.
Member
There was a problem hiding this comment.
Alright, fixing mapslang compile issue can wait I'd rather have this PR merged sooner rather than later and invoking cmake from the root directory works just fine for now. I'll do a proper review when I get home from work tomorrow. Good work though, I appreciate it!
Author
There was a problem hiding this comment.
I propose a package interface named DKFans::ADiKtED and resolve the dependencies for parent directories too.
There are possible non -lm math library linker flags in existence.
dotted
requested changes
Mar 29, 2022
Member
dotted
left a comment
dotted
left a comment
There was a problem hiding this comment.
Some super minor things to changes left, but looks good to me otherwise.
| #### CMake | ||
|
|
||
| Run | ||
| `cmake --install-prefix=/usr . && make install` |
Member
There was a problem hiding this comment.
Change to cmake . && cmake --build . && cmake --install . as CMake may have used a different generator that doesn't create a Makefile. For example:
➜ ADiKtEd git:(pr-48) ✗ CMAKE_GENERATOR=Ninja
➜ ADiKtEd git:(pr-48) ✗ cmake --install-prefix=/usr . && make install
-- Configuring done
-- Generating done
-- Build files have been written to: /home/dotted/ADiKtEd
make: *** No rule to make target 'install'. Stop.
I also don't think we should be suggesting /usr as a prefix, as in general /usr/bin refers to the folder where the OS installs its managed binaries. /usr/local is the proper prefix to use for this type of binary, and is also the default used by CMake.
Author
There was a problem hiding this comment.
I was not able to reproduce the error using Linux x86_64.
Please be more specific about the host environment.
Member
|
@jopadan nobody uses adikted anymore, wouldn't waste to much time on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.