Add citizenlab url management #1050
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add test helpers from oonimeasurements: create_jwt, create_session_token, client_with_admin_role, client_with_user_role FIXME: validation of session still fails, monkeypatch auth didn't seem to work
this is to preserve the keys in json response for backwards compatibility
update handler accepts either being None to differentiate behavior
api change in filelock 3.11.0 means that FileLock is not shared between threads by default
raises exception if lock was not held
Contributor
Author
|
There are some issues with tests failing because they don't supply all the FastAPI model validator fields. aagbsn@99c2354#diff-9d7a802cecddb40a415f7ef8a83f7e640c866377b05d1786ced83b5901705ac1R366-R368 |
Contributor
Author
|
I relaxed the validator rules and the integration tests now pass |
10 tasks
Contributor
Author
|
See: #1050 which replaces gitpython/git with dulwich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the citizenlab url management components to ooniapi
#1005
#807