-
Notifications
You must be signed in to change notification settings - Fork 7
hw: Add possibility of removing CDC cut between SoC and Cluster #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
Xeratec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, the EnAxiCdc options has no effect on what clock source is used on the cluster. In this case, it is possible that there is no CDC and the cluster is running at a different frequency than the host. Would this be a problem?
25bb89a to
df8f8c1
Compare
|
@Xeratec Yes, the parameter is used only to select whether you want the CDC or not. However, the clock signal in the RTL is still different, which means that when building the SoC top level, you must ensure that the cluster clock runs at the same frequency as the SoC clock. If this is not ensured, the system will not work. |
fischeti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
You could also use the |
Xeratec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the comment from @fischeti. Additionally, there seems to be an accidental change and I have a question about the newly added TODO comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes seem unwanted.
| ~reg2hw.reset_cluster_0.q | ||
| }; | ||
|
|
||
| // TODO: Double check that teh logic AND is sufficient! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this TODO about?
Cluster Adapter CDC
This PR introduces the possibility of enabling or disabling the CDC between the SoC and the cluster domains.
Additionally, when the CDC is enabled, it adjusts the parameter for the input FIFO depth to avoid bandwidth limitations between the two domains.