Add EventsExecutor API for dynamic_fastrtps#600
Merged
Conversation
Contributor
Yeah, agreed. I'd say let's get that fix in (I'm happy to review it), then rebase this one and get green CI. The Rpr job is going to be broken for right now until Jacob finishes doing releases for Rolling. |
clalancette
approved these changes
May 4, 2022
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
This looks reasonable to me, but let's rebase it onto the latest and run a full CI on it to make sure nothing breaks.
Mostly a copy of the implementation done for rmw_fastrtps_cpp. Fixes #599. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
To keep the both rmw_fastrtps_ implementations in sync with respect to argument checking. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
j-rivero
force-pushed
the
jrivero/executor_for_dynamic
branch
from
f2cfc82 to
ef9f429
Compare
Contributor
Author
|
CI:
|
Contributor
Author
|
Seems fine, merging. |
This was referenced May 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #599
Two commits:
Testing:
I think that cpplint is not related to this PR. I can open a new PR to fix it.