Skip to content

Assert HistoryQoS in test_ros2cli_daemon#1040

Merged
ahcorde merged 1 commit intoros2:rollingfrom
eProsima:qos/history
Jun 4, 2025
Merged

Assert HistoryQoS in test_ros2cli_daemon#1040
ahcorde merged 1 commit intoros2:rollingfrom
eProsima:qos/history

Conversation

@Mario-DL
Copy link
Contributor

@Mario-DL Mario-DL commented May 30, 2025 •
edited
Loading

Description

This PR introduces some additions to the test_get_*_info_by_topic
Related to

Is this user-facing behavior change?

N/A

Did you use Generative AI?

N/A

Additional Information

Should be backported only to Kilted

@Mario-DL
Assert HistoryQoS in test_ros2cli_daemon
3ca7290 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL mentioned this pull request May 30, 2025
Merged
@ahcorde
Copy link
Contributor

ahcorde commented May 30, 2025

Pulls: ros2/rmw_fastrtps#829, ros2/rcl#1242, #1040
Gist: https://gist.githubusercontent.com/ahcorde/e1d6b10259d33a4a01ea1e33a4dc7da6/raw/ddeaa93863d812677523326fe68db8b191509d9d/ros2.repos
BUILD args: --packages-above-and-dependencies rcl rmw_fastrtps_shared_cpp ros2cli
TEST args: --packages-above rcl rmw_fastrtps_shared_cpp ros2cli
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16136

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde mentioned this pull request May 30, 2025
Merged
fujitatomoya
fujitatomoya reviewed May 30, 2025
View reviewed changes
@ahcorde
Copy link
Contributor

ahcorde commented Jun 2, 2025 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde requested a review from fujitatomoya June 3, 2025 14:42
@ahcorde
Copy link
Contributor

ahcorde commented Jun 3, 2025

@fujitatomoya CI is green, do you mind to review it again?

@ahcorde ahcorde merged commit c0fabea into ros2:rolling Jun 4, 2025
2 of 3 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Jun 4, 2025

https://github.com/Mergifyio backport kilted

@mergify
Copy link

mergify bot commented Jun 4, 2025 •
edited
Loading

backport kilted

✅ Backports have been created

Details

@mergify mergify bot mentioned this pull request Jun 4, 2025
Merged
mergify bot pushed a commit that referenced this pull request Jun 4, 2025
@Mario-DL @mergify
Assert HistoryQoS in test_ros2cli_daemon (#1040)
90b9795 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit c0fabea)
@mergify mergify bot mentioned this pull request Jun 4, 2025
Merged
ahcorde pushed a commit that referenced this pull request Jun 4, 2025
@mergify @Mario-DL
Assert HistoryQoS in test_ros2cli_daemon (#1040) (#1044)
3b7cbc4 
(cherry picked from commit c0fabea)

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
@fujitatomoya fujitatomoya mentioned this pull request Jun 12, 2025
Closed
@Crola1702 Crola1702 mentioned this pull request Jun 30, 2025
Closed
This was referenced Oct 15, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mario-DL @ahcorde @fujitatomoya