refactor: modernize codebase, remove Angular and legacy dependencies#83
refactor: modernize codebase, remove Angular and legacy dependencies#83robertodauria wants to merge 21 commits intomainfrom
Conversation
63bc50f to
dc00538
Compare
bassosimone
left a comment
There was a problem hiding this comment.
I like the approach of picking the axe (cit.) and significantly simplifying, refactoring, and rationalizing the website. Thank you for doing this!
I do not think this branch is ready for merge. I have a bunch of questions and aspects that I find slightly troubling. I think we need to discuss and resolve those points before we move forward.
scripts/build.js
Outdated
|
|
||
| // Convert .po translations to JSON | ||
| console.log('Converting translations...'); | ||
| require('./po-to-json'); |
There was a problem hiding this comment.
I am not so amused that the generation happens as a side effect of importing. Could you please make this module such that we import w/o side effects and then we explicitly trigger the generation?
- Remove Angular 1.x, jQuery, Gulp, Bower, Skel framework - Replace with vanilla JS (app.js, gauge.js, i18n.js) - Add runtime i18n with ?lang= query param support - Simplify CSS from ~4000 to ~900 lines - Add simple Node.js build script (scripts/build.js) - Convert .po translations to JSON format - Update GitHub Actions workflows for new build - Change Firebase public dir from app/ to dist/ Dependencies reduced from ~680 to 13 packages.
- br: Folitikerezh → Politikerezh - pt: cálculo → medição, fix gender agreement
- Move assets (fonts, images, font-awesome) from app/ to src/ - Update build script to use src/assets - Remove legacy Angular app, templates, and JS translations
Co-authored-by: Simone Basso <bassosimone@gmail.com>
Co-authored-by: Simone Basso <bassosimone@gmail.com>
Co-authored-by: Simone Basso <bassosimone@gmail.com>
Co-authored-by: Simone Basso <bassosimone@gmail.com>
Co-authored-by: Simone Basso <bassosimone@gmail.com>
Co-authored-by: Simone Basso <bassosimone@gmail.com>
51b90ac to
46e1f84
Compare
|
Visit the preview URL for this PR (updated for commit 08f6f5d): https://mlab-sandbox--pr-83-nx1hjbn2.web.app (expires Mon, 02 Mar 2026 00:34:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 8e465d9b3e7c624aa653052fc53678329c9bfc07 |

Summary
?lang=query param supportDependencies reduced from ~680 to 13 packages.
Closes #42, #40, #36, #111, #147, #152