Skip to content

Conversation

@a1q123456
Copy link
Collaborator

@a1q123456 a1q123456 commented Jan 15, 2026

High Level Overview of Change

This PR modularises the walletdb and manifest. Please be aware that the wallet db actually has nothing to do with account wallets and it stores node configuration, which is why it depends on Manifest.

Context of Change

To help modularisation, the wallet db has to be modularised.

This PR is part of the modularisation of the transactors. See all PRs here:
#6222
#6223
#6224
#6225
#6226
#6227
#6228

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@a1q123456 a1q123456 requested a review from a team as a code owner January 15, 2026 12:23
@a1q123456 a1q123456 changed the title A1q123456/modularise wallet db and manifest Modularise wallet db and manifest Jan 15, 2026
@a1q123456 a1q123456 changed the title Modularise wallet db and manifest Modularise WalletDB and Manifest Jan 15, 2026
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456 a1q123456 force-pushed the a1q123456/modularise-wallet-db-and-manifest branch from af0b679 to 4e554cc Compare January 15, 2026 13:22
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 84.11765% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.2%. Comparing base (5ff7222) to head (c9dbea1).

Files with missing lines Patch % Lines
...rc/xrpld/app/rdb/backend/detail/SQLiteDatabase.cpp 54.2% 11 Missing ⚠️
src/libxrpl/rdb/DatabaseCon.cpp 64.3% 10 Missing ⚠️
src/xrpld/core/detail/ServiceRegistryImpl.cpp 60.0% 4 Missing ⚠️
src/xrpld/app/main/Application.cpp 88.9% 1 Missing ⚠️
src/xrpld/core/detail/Config.cpp 98.9% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           a1q123456/add_service_registry   #6223     +/-   ##
================================================================
- Coverage                            79.2%   79.2%   -0.0%     
================================================================
  Files                                 842     843      +1     
  Lines                               71693   71717     +24     
  Branches                             8282    8285      +3     
================================================================
+ Hits                                56777   56794     +17     
- Misses                              14916   14923      +7     
Files with missing lines Coverage Δ
include/xrpl/core/PeerReservationTable.h 25.0% <ø> (ø)
include/xrpl/core/ServiceRegistry.h 100.0% <ø> (ø)
include/xrpl/core/StartUpType.h 100.0% <100.0%> (ø)
include/xrpl/rdb/DatabaseCon.h 100.0% <100.0%> (ø)
include/xrpl/rdb/SociDB.h 100.0% <ø> (ø)
include/xrpl/server/Manifest.h 76.7% <ø> (ø)
src/libxrpl/rdb/SociDB.cpp 60.7% <ø> (ø)
src/libxrpl/server/State.cpp 89.6% <ø> (ø)
src/libxrpl/server/Vacuum.cpp 0.0% <ø> (ø)
src/libxrpl/server/Wallet.cpp 76.3% <ø> (ø)
... and 24 more

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants