Skip to content

Conversation

@a1q123456
Copy link
Collaborator

@a1q123456 a1q123456 commented Jan 15, 2026

High Level Overview of Change

This PR moves transactors and some other dependencies to libxrpl.

This PR is part of the modularisation of the transactors. See all PRs here:
#6222
#6223
#6224
#6225
#6226
#6227
#6228

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@a1q123456 a1q123456 requested a review from a team as a code owner January 15, 2026 14:59
@a1q123456 a1q123456 force-pushed the a1q123456/decouple-app-tx-with-application branch from 5f2b68b to fa276cf Compare January 15, 2026 15:06
@a1q123456 a1q123456 force-pushed the a1q123456/modularise-app-tx branch from 5cd22c3 to 001fb47 Compare January 15, 2026 15:07
@a1q123456 a1q123456 force-pushed the a1q123456/decouple-app-tx-with-application branch from fa276cf to d4e5749 Compare January 15, 2026 15:11
@a1q123456 a1q123456 force-pushed the a1q123456/modularise-app-tx branch from 001fb47 to 4ff8657 Compare January 15, 2026 15:12
@a1q123456 a1q123456 force-pushed the a1q123456/decouple-app-tx-with-application branch from d4e5749 to ab6b416 Compare January 15, 2026 15:56
@a1q123456 a1q123456 force-pushed the a1q123456/modularise-app-tx branch 2 times, most recently from 73c4fdf to 1ec88d5 Compare January 15, 2026 15:58
@a1q123456 a1q123456 force-pushed the a1q123456/decouple-app-tx-with-application branch from ab6b416 to 42f0e02 Compare January 15, 2026 16:53
@a1q123456 a1q123456 force-pushed the a1q123456/modularise-app-tx branch from 1ec88d5 to 0d2e5f1 Compare January 15, 2026 16:57
@a1q123456 a1q123456 force-pushed the a1q123456/decouple-app-tx-with-application branch from 42f0e02 to d643270 Compare January 15, 2026 18:09
@a1q123456 a1q123456 force-pushed the a1q123456/modularise-app-tx branch from 0d2e5f1 to f9f57ac Compare January 15, 2026 18:13
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456 a1q123456 force-pushed the a1q123456/modularise-app-tx branch from f9f57ac to 94932f1 Compare January 15, 2026 18:28
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.3%. Comparing base (0595bec) to head (d6fcb49).

Additional details and impacted files

Impacted file tree graph

@@                             Coverage Diff                             @@
##           a1q123456/decouple-app-tx-with-application   #6228    +/-   ##
===========================================================================
  Coverage                                        79.2%   79.3%            
===========================================================================
  Files                                             848     849     +1     
  Lines                                           71736   71875   +139     
  Branches                                         8282    8286     +4     
===========================================================================
+ Hits                                            56841   56978   +137     
- Misses                                          14895   14897     +2     
Files with missing lines Coverage Δ
include/xrpl/ledger/AmendmentTable.h 100.0% <ø> (ø)
include/xrpl/protocol/Protocol.h 100.0% <ø> (ø)
include/xrpl/protocol/detail/transactions.macro 100.0% <ø> (ø)
include/xrpl/server/LoadFeeTrack.h 90.0% <ø> (ø)
include/xrpl/tx/ApplyContext.h 100.0% <ø> (ø)
include/xrpl/tx/InvariantCheck.h 100.0% <ø> (ø)
include/xrpl/tx/SignerEntries.h 100.0% <ø> (ø)
include/xrpl/tx/Transactor.h 100.0% <ø> (ø)
include/xrpl/tx/applySteps.h 100.0% <ø> (ø)
include/xrpl/tx/paths/BookTip.h 50.0% <ø> (ø)
... and 183 more

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a1q123456 a1q123456 requested review from bthomee and ximinez January 16, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants