-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Modularise app/tx #6228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
a1q123456
wants to merge
3
commits into
a1q123456/decouple-app-tx-with-application
Choose a base branch
from
a1q123456/modularise-app-tx
base: a1q123456/decouple-app-tx-with-application
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Modularise app/tx #6228
a1q123456
wants to merge
3
commits into
a1q123456/decouple-app-tx-with-application
from
a1q123456/modularise-app-tx
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f2b68b to
fa276cf
Compare
5cd22c3 to
001fb47
Compare
fa276cf to
d4e5749
Compare
001fb47 to
4ff8657
Compare
d4e5749 to
ab6b416
Compare
73c4fdf to
1ec88d5
Compare
ab6b416 to
42f0e02
Compare
1ec88d5 to
0d2e5f1
Compare
This was referenced Jan 15, 2026
42f0e02 to
d643270
Compare
0d2e5f1 to
f9f57ac
Compare
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
f9f57ac to
94932f1
Compare
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## a1q123456/decouple-app-tx-with-application #6228 +/- ##
===========================================================================
Coverage 79.2% 79.3%
===========================================================================
Files 848 849 +1
Lines 71736 71875 +139
Branches 8282 8286 +4
===========================================================================
+ Hits 56841 56978 +137
- Misses 14895 14897 +2
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR moves transactors and some other dependencies to libxrpl.
This PR is part of the modularisation of the transactors. See all PRs here:
#6222
#6223
#6224
#6225
#6226
#6227
#6228
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)