-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Decouple app/tx with Application and Config #6227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
a1q123456
wants to merge
2
commits into
a1q123456/modularise-hashrouter-conditions-and-orderbookdb
Choose a base branch
from
a1q123456/decouple-app-tx-with-application
base: a1q123456/modularise-hashrouter-conditions-and-orderbookdb
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Decouple app/tx with Application and Config #6227
a1q123456
wants to merge
2
commits into
a1q123456/modularise-hashrouter-conditions-and-orderbookdb
from
a1q123456/decouple-app-tx-with-application
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb39fa3 to
5733073
Compare
fa276cf to
d4e5749
Compare
4d15d4e to
1029221
Compare
d4e5749 to
ab6b416
Compare
1fb3a22 to
b6650f4
Compare
ab6b416 to
42f0e02
Compare
This was referenced Jan 15, 2026
42f0e02 to
d643270
Compare
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## a1q123456/modularise-hashrouter-conditions-and-orderbookdb #6227 +/- ##
==========================================================================================
Coverage 79.2% 79.2%
==========================================================================================
Files 845 848 +3
Lines 71719 71736 +17
Branches 8277 8282 +5
==========================================================================================
+ Hits 56816 56841 +25
+ Misses 14903 14895 -8
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR decouples app/tx with Application and Config to clear the way to moving transactors to libxrpl.
This PR is part of the modularisation of the transactors. See all PRs here:
#6222
#6223
#6224
#6225
#6226
#6227
#6228
Type of Change
.gitignore, formatting, dropping support for older tooling)