Skip to content

Conversation

@a1q123456
Copy link
Collaborator

@a1q123456 a1q123456 commented Jan 15, 2026

High Level Overview of Change

This PR decouples app/tx with Application and Config to clear the way to moving transactors to libxrpl.

This PR is part of the modularisation of the transactors. See all PRs here:
#6222
#6223
#6224
#6225
#6226
#6227
#6228

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@a1q123456 a1q123456 requested a review from a team as a code owner January 15, 2026 14:52
@a1q123456 a1q123456 force-pushed the a1q123456/modularise-hashrouter-conditions-and-orderbookdb branch from fb39fa3 to 5733073 Compare January 15, 2026 15:05
@a1q123456 a1q123456 force-pushed the a1q123456/decouple-app-tx-with-application branch 2 times, most recently from fa276cf to d4e5749 Compare January 15, 2026 15:11
@a1q123456 a1q123456 force-pushed the a1q123456/modularise-hashrouter-conditions-and-orderbookdb branch from 4d15d4e to 1029221 Compare January 15, 2026 15:55
@a1q123456 a1q123456 force-pushed the a1q123456/decouple-app-tx-with-application branch from d4e5749 to ab6b416 Compare January 15, 2026 15:56
@a1q123456 a1q123456 force-pushed the a1q123456/modularise-hashrouter-conditions-and-orderbookdb branch 3 times, most recently from 1fb3a22 to b6650f4 Compare January 15, 2026 16:51
@a1q123456 a1q123456 force-pushed the a1q123456/decouple-app-tx-with-application branch from ab6b416 to 42f0e02 Compare January 15, 2026 16:53
@a1q123456 a1q123456 force-pushed the a1q123456/decouple-app-tx-with-application branch from 42f0e02 to d643270 Compare January 15, 2026 18:09
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 96.90722% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.2%. Comparing base (883d0d6) to head (0595bec).

Files with missing lines Patch % Lines
src/xrpld/app/misc/NetworkOPs.cpp 50.0% 1 Missing ⚠️
src/xrpld/app/tx/detail/Change.cpp 75.0% 1 Missing ⚠️
src/xrpld/overlay/detail/PeerImp.cpp 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                                    Coverage Diff                                     @@
##           a1q123456/modularise-hashrouter-conditions-and-orderbookdb   #6227   +/-   ##
==========================================================================================
  Coverage                                                        79.2%   79.2%           
==========================================================================================
  Files                                                             845     848    +3     
  Lines                                                           71719   71736   +17     
  Branches                                                         8277    8282    +5     
==========================================================================================
+ Hits                                                            56816   56841   +25     
+ Misses                                                          14903   14895    -8     
Files with missing lines Coverage Δ
include/xrpl/core/NetworkIDService.h 100.0% <100.0%> (ø)
include/xrpl/core/ServiceRegistry.h 100.0% <ø> (ø)
src/xrpld/app/ledger/detail/BuildLedger.cpp 92.0% <100.0%> (+0.3%) ⬆️
src/xrpld/app/ledger/detail/OpenLedger.cpp 70.6% <100.0%> (ø)
src/xrpld/app/main/Application.cpp 69.0% <100.0%> (+0.1%) ⬆️
src/xrpld/app/main/Application.h 100.0% <ø> (ø)
src/xrpld/app/misc/detail/TxQ.cpp 97.7% <100.0%> (+<0.1%) ⬆️
src/xrpld/app/tx/applySteps.h 100.0% <ø> (ø)
src/xrpld/app/tx/detail/AMMCreate.cpp 92.0% <100.0%> (ø)
src/xrpld/app/tx/detail/ApplyContext.cpp 100.0% <100.0%> (ø)
... and 29 more

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants