Skip to content

Conversation

@a1q123456
Copy link
Collaborator

@a1q123456 a1q123456 commented Jan 15, 2026

High Level Overview of Change

This PR modularises HashRouter, xrpld/conditions, and OrderBookDB to libxrpl to help modularisation.

Context of Change

app/tx depends on those components so we need to modularise them.

This PR is part of the modularisation of the transactors. See all PRs here:
#6222
#6223
#6224
#6225
#6226
#6227
#6228

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@a1q123456 a1q123456 requested a review from a team as a code owner January 15, 2026 14:45
@a1q123456 a1q123456 force-pushed the a1q123456/modularise-networkops-interface branch from 0eaf893 to f518ca5 Compare January 15, 2026 15:05
@a1q123456 a1q123456 force-pushed the a1q123456/modularise-hashrouter-conditions-and-orderbookdb branch from fb39fa3 to 5733073 Compare January 15, 2026 15:05
@a1q123456 a1q123456 force-pushed the a1q123456/modularise-networkops-interface branch from f518ca5 to 5df4f28 Compare January 15, 2026 15:55
@a1q123456 a1q123456 force-pushed the a1q123456/modularise-hashrouter-conditions-and-orderbookdb branch from 4d15d4e to 1029221 Compare January 15, 2026 15:55
@a1q123456 a1q123456 force-pushed the a1q123456/modularise-networkops-interface branch from 5df4f28 to 44dc0ef Compare January 15, 2026 16:27
@a1q123456 a1q123456 force-pushed the a1q123456/modularise-hashrouter-conditions-and-orderbookdb branch 2 times, most recently from 4e31ea1 to 1fb3a22 Compare January 15, 2026 16:34
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 92.72727% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.2%. Comparing base (f518dd5) to head (883d0d6).

Files with missing lines Patch % Lines
src/xrpld/core/detail/ServiceRegistryImpl.cpp 50.0% 2 Missing ⚠️
src/xrpld/app/ledger/OrderBookDBImpl.cpp 96.0% 1 Missing ⚠️
src/xrpld/app/misc/NetworkOPs.cpp 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                             Coverage Diff                             @@
##           a1q123456/modularise-networkops-interface   #6226     +/-   ##
===========================================================================
+ Coverage                                       79.2%   79.2%   +0.1%     
===========================================================================
  Files                                            843     845      +2     
  Lines                                          71694   71719     +25     
  Branches                                        8304    8277     -27     
===========================================================================
+ Hits                                           56758   56816     +58     
+ Misses                                         14936   14903     -33     
Files with missing lines Coverage Δ
include/xrpl/conditions/Condition.h 100.0% <ø> (ø)
include/xrpl/conditions/Fulfillment.h 100.0% <ø> (ø)
include/xrpl/conditions/detail/PreimageSha256.h 77.8% <ø> (ø)
include/xrpl/conditions/detail/utils.h 69.9% <ø> (ø)
include/xrpl/core/HashRouter.h 100.0% <ø> (ø)
include/xrpl/core/ServiceRegistry.h 100.0% <ø> (ø)
include/xrpl/ledger/AcceptedLedgerTx.h 100.0% <ø> (ø)
include/xrpl/ledger/BookListeners.h 100.0% <ø> (ø)
include/xrpl/ledger/OrderBookDB.h 100.0% <100.0%> (ø)
src/libxrpl/conditions/Condition.cpp 56.6% <ø> (ø)
... and 39 more

... and 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a1q123456 a1q123456 requested a review from ximinez January 16, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants