-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Modularise HashRouter, Conditions, and OrderBookDB #6226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
a1q123456
wants to merge
9
commits into
a1q123456/modularise-networkops-interface
Choose a base branch
from
a1q123456/modularise-hashrouter-conditions-and-orderbookdb
base: a1q123456/modularise-networkops-interface
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Modularise HashRouter, Conditions, and OrderBookDB #6226
a1q123456
wants to merge
9
commits into
a1q123456/modularise-networkops-interface
from
a1q123456/modularise-hashrouter-conditions-and-orderbookdb
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0eaf893 to
f518ca5
Compare
fb39fa3 to
5733073
Compare
f518ca5 to
5df4f28
Compare
4d15d4e to
1029221
Compare
5df4f28 to
44dc0ef
Compare
4e31ea1 to
1fb3a22
Compare
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
1fb3a22 to
b6650f4
Compare
This was referenced Jan 15, 2026
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## a1q123456/modularise-networkops-interface #6226 +/- ##
===========================================================================
+ Coverage 79.2% 79.2% +0.1%
===========================================================================
Files 843 845 +2
Lines 71694 71719 +25
Branches 8304 8277 -27
===========================================================================
+ Hits 56758 56816 +58
+ Misses 14936 14903 -33
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR modularises HashRouter, xrpld/conditions, and OrderBookDB to libxrpl to help modularisation.
Context of Change
app/tx depends on those components so we need to modularise them.
This PR is part of the modularisation of the transactors. See all PRs here:
#6222
#6223
#6224
#6225
#6226
#6227
#6228
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)