Modularise RelationalDB #6224
Open
Modularise RelationalDB #6224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1q123456
force-pushed
the
a1q123456/modularise-relational-db
branch
2 times, most recently
from
b7d8cbe to
32296b7
Compare
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
a1q123456
force-pushed
the
a1q123456/modularise-relational-db
branch
from
dd1a1a9 to
cf67641
Compare
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## a1q123456/modularise-wallet-db-and-manifest #6224 +/- ##
===========================================================================
Coverage 79.2% 79.2%
===========================================================================
Files 843 843
Lines 71717 71694 -23
Branches 8285 8284 -1
===========================================================================
- Hits 56794 56780 -14
+ Misses 14923 14914 -9
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This was referenced Jan 15, 2026
kuznetsss
reviewed
Jan 23, 2026
Comment on lines
+53
to
+54
| std::uint32_t minLedger; | ||
| std::uint32_t maxLedger; |
| using AccountTx = | ||
| std::pair<std::shared_ptr<Transaction>, std::shared_ptr<TxMeta>>; | ||
| using AccountTxs = std::vector<AccountTx>; | ||
| using txnMetaLedgerType = std::tuple<Blob, Blob, std::uint32_t>; |
Contributor
There was a problem hiding this comment.
Better to avoid pairs and tuples if possible because they decrease readability
| closeTransactionDB() = 0; | ||
| }; | ||
|
|
||
| template <class T, class C> |
Contributor
There was a problem hiding this comment.
Please add concepts on T and C to improve compilation errors on misuse. Probably std::is_arithmetic and that std::is_convertible.
| closeTransactionDB() override; | ||
|
|
||
| std::optional<LedgerHeader> | ||
| getLedgerInfoByIndex(LedgerIndex ledgerSeq) override; |
Contributor
There was a problem hiding this comment.
Please add docs comments for added methods for consistency
| std::optional<LedgerHeader> | ||
| getNewestLedgerInfo() override; | ||
|
|
||
| SQLiteDatabase( |
Contributor
There was a problem hiding this comment.
Maybe move the implementation into cpp file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR modularise xrpld/rdb
Context of Change
The rdb module was not properly designed. We have 3 classes:
RelationalDBand adds some more pure virtual methodsSQLiteDatabaseand implements all the methods.The factory function
RelationalDB::initmethod checks the config and only returns an instance of SQLiteDatabaseImp, we can see in the code base that we are doingdynamic_cast<SQLiteDatabase*>(app.getRelationalDb())everywhere.To address this problem and help modularise app/tx, the rdb module needs to be refactored and moved to libxrpl.
This PR is part of the modularisation of the transactors. See all PRs here:
#6222
#6223
#6224
#6225
#6226
#6227
#6228
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)